Re: pointless assignment in http.c, obsolete enum in enums.h

David Luyer writes:

>typhaon; grep clen http.c
> int clen;
> clen = entry->mem_obj->inmem_hi; ***
> for (clen = len - 1, bin = 0; clen; bin++)
> clen >>= 1;
>
>The value of clen assigned on the line labeled *** is never used.

yep.

>Also, in enums.h, the enum objcache_op which is now obsolete is
>defined.

yep.

>Also another one, the essence of my current problem -
>src/snmp_agent.c: *(Answer->val.integer) = IOStats.Http.reads_deferred;
>src/stat.c: storeAppendPrintf(sentry, "deferred reads: %d (%d%%)\n",
>src/stat.c: IOStats.Http.reads_deferred,
>src/stat.c: percent(IOStats.Http.reads_deferred, IOStats.Http.reads));
>src/stat.c: storeAppendPrintf(sentry, "deferred reads: %d (%d%%)\n",
>src/stat.c: IOStats.Ftp.reads_deferred,
>src/stat.c: percent(IOStats.Ftp.reads_deferred, IOStats.Ftp.reads));
>src/stat.c: storeAppendPrintf(sentry, "deferred reads: %d (%d%%)\n",
>src/stat.c: IOStats.Gopher.reads_deferred,
>src/stat.c: percent(IOStats.Gopher.reads_deferred, IOStats.Gopher.reads))
;
>src/stat.c: storeAppendPrintf(sentry, "deferred reads: %d (%d%%)\n",
>src/stat.c: IOStats.Wais.reads_deferred,
>src/stat.c: percent(IOStats.Wais.reads_deferred, IOStats.Wais.reads));
>src/structs.h: int reads_deferred;

yep.

thanks!

>I can't see where I should be deferring the reads now as easily as it used
>to be, and as far as I can see these stats would always be 0 now (never
>updated anywhere I can see??)
>
>What should I do now to defer reads?

The select loop calls a registered defer function for every socket.
Probably you want to pollute^H^H^H^H^H^H^Hmodify fwdCheckDeferRead().

Duane W.
Received on Tue Jul 29 2003 - 13:15:51 MDT